Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

aria-allowed-attr should incomplete attributes with a falsey value #4463

Open
WilcoFiers opened this issue May 15, 2024 · 0 comments
Open

aria-allowed-attr should incomplete attributes with a falsey value #4463

WilcoFiers opened this issue May 15, 2024 · 0 comments
Assignees
Labels
fix Bug fixes rules Issue or false result from an axe-core rule support
Milestone

Comments

@WilcoFiers
Copy link
Contributor

WilcoFiers commented May 15, 2024

Had a question about this aria-multieline=false failing the aria-allowed-attr rule. This doesn't seem to impact screen reader use. Instead of raising this as an issue I think it would be better to report this as needing review. If at some point in the lifecycle of that component the state changes to true, there is a problem (since this information won't be available in the accessibility tree). But while this is false, failing this is inappropriate.

<!-- This incompletes / needs review -->
<div aria-multiline="false" tabindex="0" aria-labelledby="foo" role="combobox">

This fix should only apply to attributes that are allowed "false" as a value. The same probably holds for attributes with "undefined" as a valid value. That's rare though.

Update

Turns out the reason people sometimes do this is to avoid an issue where VoiceOver announces elements with contenteditable as multiline. Since a combobox cannot be multiline, this attribute is needed to ensure its announced as being a single line. So while I think the above example should incomplete, I think if this happens on an element with contenteditable axe-core should pass the rule:

<!-- This passes -->
<div aria-multiline="false" tabindex="0" aria-labelledby="foo" role="combobox" contenteditable>
@WilcoFiers WilcoFiers added fix Bug fixes rules Issue or false result from an axe-core rule support labels May 15, 2024
@WilcoFiers WilcoFiers added this to the Axe-core 4.10 milestone May 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix Bug fixes rules Issue or false result from an axe-core rule support
Projects
None yet
Development

No branches or pull requests

2 participants