fix: td-has-heading to ignore td with its role changed #928

WilcoFiers · 2018-05-28T13:53:05Z

PR Checklist

Please check if your PR fulfills the following requirements:

The commit message(s) follow our guidelines: https://github.com/dequelabs/axe-core/blob/develop/doc/code-submission-guidelines.md#git-commits
Changes to rules and checks appropriately support Shadow DOM
Changes have been tested in major browsers and Assistive Technologies
Tests for the changes have been added (for bug fixes / features)
Docs have been added / updated (for bug fixes / features)

jeeyyy · 2018-05-28T14:26:06Z

test/commons/table/is-data-cell.js

+		assert.isFalse(axe.commons.table.isDataCell(target3));
+	});
+
+	it('should return true for elements with role="(grid)cell"', function () {


role="(grid)cell" - what is the intention behind the brackets around (grid)? Tests for 2 scenarios?, worth separating?

role=gridcell and role=cell I don't see the point of separate cases. It's the same functionality. It's just data.

jeeyyy reviewed May 28, 2018

View reviewed changes

fix: td-has-heading to ignore td with its role changed

de656ee

WilcoFiers force-pushed the td-has-rowheader branch from 1ef4a21 to de656ee Compare May 28, 2018 14:37

jeeyyy approved these changes Jun 1, 2018

View reviewed changes

WilcoFiers merged commit d68af4c into develop Jun 4, 2018

WilcoFiers deleted the td-has-rowheader branch June 4, 2018 13:33