'landmark-no-duplicate-banner' & 'landmark-no-duplicate-contentinfo' return incorrect element source

[iamrafan]

All the elements that fail these two rules are return as related nodes unlike in the case of duplicate-id failures, where the first matching node is returned as a failure node and the rest of the nodes are returned as related nodes

axe-core version: 3.0.3
axe-Coconut version: 3.4.0-alpha.2

[WilcoFiers]

This is the same issue as #878.

[WilcoFiers]

Proposal to use the after function to turn the related nodes into matched nodes, so that the result would go from look like this:

[{
   target: 'html'
   relatedNode: [{
     target: '#div1'
   }, {
     target: '#div2'
   }, {
     target: '#div3'
   }]
}]

to looking like this:

[{
  target: '#div1',
  relatedNodes: [{
    target: 'html'
  }]
}, {
  target: '#div2',
  relatedNodes: [{
    target: 'html'
  }]
}, {
  target: '#div3',
  relatedNodes: [{
    target: 'html'
  }]
}]

[marcysutton]

We also talked about limiting results to common ancestors, so we don't get a bunch of extra noise. This will take the region rule from one result to many, to make it easier to understand.

[WilcoFiers]

Me and Jey have been looking into this, and it isn't as simple as tweaking the data in "after". Unfortunately axe-core doesn't let you flip related nodes and selected nodes. We'd have to rewrite these rules to do this I think, which is a bummer. I do think that's probably the right way to do it.

[WilcoFiers]

Talking to Steve about this. The way to deal with this is to select all the landmarks in the rule, and use the after method to remove any duplicates after the first. This would be similar to how we do it in #1787 and #1649.

[jeankaplansky]

new rule landmark-no-duplicate-main infrastructure created 1/27/2020

[jeankaplansky]

landmark-no-duplicate-main rule create in axe-core rule help and release notes 2/03/2020

[padmavemulapati]

Ensuring no duplicate landmarks , verified with the latest axe.