Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[A11y] - Label does not convey purpose of control #1389

Open
1 of 5 tasks
VaniChinnam opened this issue Mar 8, 2024 · 2 comments · Fixed by #1406
Open
1 of 5 tasks

[A11y] - Label does not convey purpose of control #1389

VaniChinnam opened this issue Mar 8, 2024 · 2 comments · Fixed by #1406
Labels
accessibility vpat:serious Serious issues found during a vpat
Milestone

Comments

@VaniChinnam
Copy link

VaniChinnam commented Mar 8, 2024

Current Behaviour

The label does not convey the purpose of the control.


Expected Behaviour

RULE : Labels MUST be meaningful. HOW TO FIX: Fix this issue by providing a descriptive label for the control.


Impact

  • Blocker
  • Serious
  • Critical
  • Moderate
  • Minor

Issue Details

View Issue 1686753

Auditor ID : 1686753

description : Show/ Hide Panel
Element location: In the "Default, With Optional Group Headings" sections.

Expected name:
Show Items panel/ Hide items panel
Show Grouped Items panel/ Hide Grouped Items panel

Page Name : Two column panel

source : <button type="button" aria-label="Hide Panel" aria-expanded="true" aria-controls="sidebar-9" aria-labelledby="tooltip11">

Screenshots : Show panel

View Issue 1686754

Auditor ID : 1686754

description : Grouped items region label is given as "OPTIONAL GROUP HEADING" instead of "Grouped Items".

Element location: In the section "With Optional Group Headings".

Page Name : Two column panel

source : `


...

Optional group heading

`

Screenshots : Group label

@VaniChinnam VaniChinnam added A11y vpat Issues found during a vpat WCAG 2.4.6 labels Mar 8, 2024
@scurker scurker added accessibility vpat:serious Serious issues found during a vpat and removed A11y labels Mar 8, 2024
@scurker
Copy link
Member

scurker commented Mar 12, 2024

For the first example, we're showing 2 examples of of the same component with its default label that we shouldn't directly change because they're specifically examples that would ideally be isolated. In real practice, there would not be 2 of these components on the same page so they're a bit out of context here but these labels should not change for the purpose of documentation.

For the 2nd issue, that can be quickly fixed in documentation.

@scurker
Copy link
Member

scurker commented Apr 17, 2024

After discussing with @VaniChinnam and subject matter experts the path forward is to add an aria-described to the toggle button so that we can meet in the middle.

@scurker scurker reopened this Apr 17, 2024
@scurker scurker added this to the Q2 2024 milestone Apr 17, 2024
@github-actions github-actions bot removed vpat Issues found during a vpat WCAG 2.4.6 labels May 1, 2024
@scurker scurker modified the milestones: Q2 2024, Q3 2024 Jul 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accessibility vpat:serious Serious issues found during a vpat
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants