feat(*): convert to typescript #137

straker · 2020-02-19T18:31:33Z

This one was a bit tricky with all the private property lookups in axe-core and React.

Reviewer checks

Required fields, to be filled out by PR reviewer(s)

Follows the commit message policy, appropriate for next version
Code is reviewed for security

stephenmathieson

Small things.

index.ts

package.json

Resolved

stephenmathieson

1 small thing. This LGTM tho!

index.ts

stephenmathieson

LGTM.

Please get a second approval on this tho. I am not very familiar with this project.

index.ts

scurker

Noticed 2 minor things

Resolved

scurker

I think this looks good, I don't see anything glaring

dgrant85 · 2020-05-27T11:56:55Z

Has this been released?

Version pulled from npm does not include type declarations and is listed on npmjs.com as 3.4.1, whereas develop is currently at 3.4.0?

straker · 2020-05-27T14:25:17Z

It does not appear types was released to npm. As for the version discrepancy, seems we never pulled master back into develop after the release.

straker added 2 commits February 19, 2020 11:28

feat(*): convert to typescript

b34df08

put back eslint for test

d1edc15

straker requested review from stephenmathieson and scurker February 19, 2020 18:31

straker requested a review from WilcoFiers as a code owner February 19, 2020 18:31

compile for test

137c408

stephenmathieson previously requested changes Feb 19, 2020

View reviewed changes

index.ts Outdated Show resolved Hide resolved

index.ts Outdated Show resolved Hide resolved

package.json Outdated Show resolved Hide resolved

fix requestidlecallback type

98e598c

stephenmathieson reviewed Feb 20, 2020

View reviewed changes

index.ts Outdated Show resolved Hide resolved

fix function

693285d

stephenmathieson previously approved these changes Feb 20, 2020

View reviewed changes

scurker reviewed Feb 20, 2020

View reviewed changes

index.ts Outdated Show resolved Hide resolved

scurker reviewed Feb 20, 2020

View reviewed changes

index.ts Outdated Show resolved Hide resolved

scurker previously requested changes Feb 20, 2020

View reviewed changes

correct axe name

82090ea

straker dismissed stephenmathieson’s stale review via 82090ea February 20, 2020 20:46

scurker approved these changes Feb 20, 2020

View reviewed changes

stephenmathieson approved these changes Feb 21, 2020

View reviewed changes

straker merged commit 261d358 into develop Feb 21, 2020

straker deleted the typescript branch February 21, 2020 16:09

straker mentioned this pull request Feb 21, 2020

feat: Support Axe-core context param #127

Merged

2 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(*): convert to typescript #137

feat(*): convert to typescript #137

straker commented Feb 19, 2020 •

edited by stephenmathieson

stephenmathieson left a comment

stephenmathieson left a comment

stephenmathieson left a comment

scurker left a comment

scurker left a comment

dgrant85 commented May 27, 2020

straker commented May 27, 2020 •

edited

feat(*): convert to typescript #137

feat(*): convert to typescript #137

Conversation

straker commented Feb 19, 2020 • edited by stephenmathieson

Reviewer checks

stephenmathieson left a comment

Choose a reason for hiding this comment

stephenmathieson left a comment

Choose a reason for hiding this comment

stephenmathieson left a comment

Choose a reason for hiding this comment

scurker left a comment

Choose a reason for hiding this comment

scurker left a comment

Choose a reason for hiding this comment

dgrant85 commented May 27, 2020

straker commented May 27, 2020 • edited

straker commented Feb 19, 2020 •

edited by stephenmathieson

straker commented May 27, 2020 •

edited