Skip to content
This repository has been archived by the owner on Mar 19, 2021. It is now read-only.

fix: Fire debounced checkNode on leading edge #147

Merged
merged 1 commit into from
Jun 16, 2020
Merged

fix: Fire debounced checkNode on leading edge #147

merged 1 commit into from
Jun 16, 2020

Conversation

JiaboHou
Copy link
Contributor

@JiaboHou JiaboHou commented Jun 4, 2020

Taken from @dambusm's fork

This PR fixes issues with checking unmounted nodes and the resulting console errors.

Example console error:
image

Closes issue: #144

Reviewer checks

Required fields, to be filled out by PR reviewer(s)

  • Follows the commit message policy, appropriate for next version
  • Code is reviewed for security

fixes issues with checking unmounted nodes
@JiaboHou JiaboHou requested a review from WilcoFiers as a code owner June 4, 2020 20:49
@CLAassistant
Copy link

CLAassistant commented Jun 4, 2020

CLA assistant check
All committers have signed the CLA.

@straker
Copy link
Contributor

straker commented Jun 8, 2020

Thanks for the pr. @dambusm have you noticed any issues with firing on the leading edge? Does getting the results first, but not again until the end of the debounce timer cause any confusion?

@will-ks
Copy link

will-ks commented Jun 10, 2020

Thanks for the pr. @dambusm have you noticed any issues with firing on the leading edge? Does getting the results first, but not again until the end of the debounce timer cause any confusion?

I'm afraid I haven't had time to test it properly so far, hence not submitting it as a PR myself. I am going to try and grab some time today to play around with it some more and write up some tests.

@straker
Copy link
Contributor

straker commented Jun 15, 2020

@dambusm any update? If not I think I'm going to merge the pr by end of day.

@will-ks
Copy link

will-ks commented Jun 16, 2020

I wasn't able to write any tests unfortunately, but I've been using a build with this change on my production project and haven't noticed any ill effects, and the console errors are definitely gone.

@straker straker merged commit 055dc2b into dequelabs:develop Jun 16, 2020
@straker straker mentioned this pull request Jun 16, 2020
2 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants