New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Material with "Metalness" but no Normal Map should emit warning #353

Closed
tngreene opened this Issue May 23, 2018 · 1 comment

Comments

Projects
None yet
1 participant
@tngreene
Copy link
Collaborator

tngreene commented May 23, 2018

From a conversation we had one person was confused about material usage:

What happened:

  • User created new file, was surprised to see the supposedly (it is) depricated ATTR_shiny_rat in the OBJ
  • It was revealed the user did not check 'Normal Metalness'
  • It was revealed that NORMAL_METALNESS was not applied because there was no normal map used

There is a validation warning not being used here: Material with "metalness" but no normal map should emit a warning.

tngreene added a commit that referenced this issue Jul 17, 2018

Fixes #353, to emit a warning when a material with normal metalness h…
…as no normal Texture. Although they didn't end up being used, warnings can be put into validations very nicely now.
@tngreene

This comment has been minimized.

Copy link
Collaborator

tngreene commented Jul 17, 2018

  • Warning
  • Unit Test

@tngreene tngreene self-assigned this Jul 23, 2018

@tngreene tngreene added this to the v3.5 milestone Jul 23, 2018

@tngreene tngreene closed this Jul 23, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment