Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Material with "Metalness" but no Normal Map should emit warning #353

Closed
tngreene opened this issue May 23, 2018 · 1 comment
Closed

Material with "Metalness" but no Normal Map should emit warning #353

tngreene opened this issue May 23, 2018 · 1 comment
Assignees
@tngreene
Labels
priority low
Milestone
v3.5.0-rc.1

Comments

@tngreene
Copy link
Contributor

From a conversation we had one person was confused about material usage:

What happened:

  • User created new file, was surprised to see the supposedly (it is) depricated ATTR_shiny_rat in the OBJ
  • It was revealed the user did not check 'Normal Metalness'
  • It was revealed that NORMAL_METALNESS was not applied because there was no normal map used

There is a validation warning not being used here: Material with "metalness" but no normal map should emit a warning.
@tngreene tngreene mentioned this issue Jun 26, 2018
Closed
tngreene added a commit that referenced this issue Jul 17, 2018
@tngreene
Fixes #353, to emit a warning when a material with normal metalness h…
72f37a3 
…as no normal Texture. Although they didn't end up being used, warnings can be put into validations very nicely now.
@tngreene
Copy link
Contributor Author

tngreene commented Jul 17, 2018 •
edited

  • Warning
  • Unit Test

@tngreene tngreene self-assigned this Jul 23, 2018
@tngreene tngreene added this to the v3.5 milestone Jul 23, 2018
@tngreene tngreene mentioned this issue Aug 10, 2018
Closed
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tngreene tngreene

Labels
priority low
Projects
None yet
Milestone
v3.5.0-rc.1
Development

No branches or pull requests
1 participant
@tngreene