Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEAT] Ignore Codeblock or specific folders #5

Closed
Quorafind opened this issue Sep 26, 2022 · 6 comments
Closed

[FEAT] Ignore Codeblock or specific folders #5

Quorafind opened this issue Sep 26, 2022 · 6 comments
Labels
enhancement New feature or request

Comments

@Quorafind
Copy link

Is it possible to ignore codeblock or specific folders?

@MarcelH20
Copy link

Hi,
I tried your plugin in my environment. First it is super cool to have the ability to mention someone on some notes etc. But I got the issue directly, because I write code snippets and ideas to my notes (e.g. annotations in java). Now I have several annotation mentions.. :D

It would be nice if you can integrate this feature.

@Test
class MyClass {}

@der-tobi der-tobi added the enhancement New feature or request label Oct 6, 2022
@der-tobi
Copy link
Owner

der-tobi commented Oct 6, 2022

Maybe a setting option to exclude codeblocks? Or what would you prefer? Will look into this after fixing the performance issues.

@MarcelH20
Copy link

Hi,

configuration options is always a good option. But I'm not sure what the default should be. From my developer view I can't think about a use-case where I use mentions within a code block. Maybe only the search result will be thereby inflated.

It depends on the solution whether you should tags within a code block to the search result, I guess.

What do you think?

@der-tobi
Copy link
Owner

Hi @MarcelH20

Good points.

It also affects the suggestions and registering of mentions. I don't think I would want @test in my suggestions list, nor should the list appear when writing within a code block.
So my first gut feeling for a simple solution is to exclude mentions in code blocks by default and make them available via configuration options.

@daniloqueiroz
Copy link

On the same note, it would be nice if it also ignore the attachments folder (if configured). I'm getting a bunch of "mentions" from the binary files i have on my attachments folder:

image

image

@der-tobi
Copy link
Owner

Version 1.0.0 has just been released (https://github.com/der-tobi/obsidian-simple-mention/tree/1.0.0).
With this version you can now exclude certain directories from indexing. Furthermore, code blocks are ignored and the plugin now only indexes Markdown files.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants