Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Helm releases view broken after interacting with a release in v0.25.21 #1639

Closed
j2udev opened this issue Jul 1, 2022 · 3 comments
Closed

Helm releases view broken after interacting with a release in v0.25.21 #1639

j2udev opened this issue Jul 1, 2022 · 3 comments
Labels
bug Something isn't working

Comments

@j2udev
Copy link
Contributor

j2udev commented Jul 1, 2022 •
edited




Describe the bug
It appears version v0.25.21 introduced an issue when leaving the Helm values view (or after hitting enter on a release) and going back to the Helm releases view. Only the release for which you check the values is showing up.

To Reproduce
Steps to reproduce the behavior:

  1. Go to the Helm releases view (with more than a single release) :helm
  2. View the values for a release v
  3. Exit the values view esc
  4. See that there is now only a single release shown.

Expected behavior
All releases are still shown

Screenshots
If applicable, add screenshots to help explain your problem.

Versions (please complete the following information):

  • OS: Darwin ARM64
  • K9s: v0.25.21
  • K8s: v1.22.5

Additional context
I'm looking into it currently. After some very early investigation, looks like it's a result of the changes to the EnsureHelmConfig function in dao/helm.go. Digging deeper.
@j2udev j2udev mentioned this issue Jul 1, 2022
Closed
@LarsBingBong
Copy link

Seeing the same thing.

@j2udev j2udev changed the title Helm releases view broken after viewing values for a particular release in v0.25.21 Helm releases view broken after interacting with a particular release in v0.25.21 Jul 13, 2022
@j2udev j2udev changed the title Helm releases view broken after interacting with a particular release in v0.25.21 Helm releases view broken after interacting with a release in v0.25.21 Jul 13, 2022
@derailed derailed mentioned this issue Jul 17, 2022
Merged
@derailed derailed added the bug Something isn't working label Jul 18, 2022
@derailed
Copy link
Owner

@j2udevelopment Fixed v0.26.0...

@j2udev
Copy link
Contributor Author

j2udev commented Jul 18, 2022

@j2udevelopment Fixed v0.26.0...

Closed my pr! Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@derailed @j2udev @LarsBingBong