Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add labels to Shell node pod #1856

Closed
ruben-rodriguez opened this issue Nov 10, 2022 · 0 comments · Fixed by #1847
Closed

Add labels to Shell node pod #1856

ruben-rodriguez opened this issue Nov 10, 2022 · 0 comments · Fixed by #1847
Labels
enhancement New feature or request

Comments

@ruben-rodriguez
Copy link
Contributor




Is your feature request related to a problem? Please describe.
Some environments often enforce labeling policies that doesn't allow to run workloads without certain mandatory labels. The current node shell pod is created without any label and it is not possible to customize them.

Describe the solution you'd like
I'd like to be able to configure the Shell node Pod metadata labels from the configuration like this

# $XDG_CONFIG_HOME/k9s/config.yml
k9s:
  clusters:
    # Configures node shell on cluster blee
    blee:
      featureGates:
        # You must enable the nodeShell feature gate to enable shelling into nodes
        nodeShell: true
      # You can also further tune the shell pod specification
      shellPod:
        image: cool_kid_admin:42
        namespace: blee
        limits:
          cpu: 100m
          memory: 100Mi
        labels:
          app.kubernetes.io/instance: k9s-node-shell
          app.kubernetes.io/managed-by: Ruben
          app.kubernetes.io/name: k9s-node-shell

Describe alternatives you've considered
#1847

Additional context
I'm sorry, I created the PR but forgot to submit this issue first 😅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants