Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ask for confirmation before deletion #21

Closed
matthyx opened this issue Feb 6, 2019 · 9 comments
Closed

Ask for confirmation before deletion #21

matthyx opened this issue Feb 6, 2019 · 9 comments
Labels
enhancement New feature or request

Comments

@matthyx
Copy link

matthyx commented Feb 6, 2019

Probably it's my particular keyboard, but D and E are so close that sometimes I hit D instead of E when editing a deployment... and there it goes!
Would it be possible to ask for user confirmation before deleting a resource? (could be a config toggle)

@jonasholtkamp
Copy link

Same for Ctrl+S when trying to switch. I accidentally deleted a context

@derailed
Copy link
Owner

derailed commented Feb 6, 2019

Thanks you for reporting back! I am not a big fan of are you sure?
Perhaps a more complicated key sequence for potentially destructive operations would fit that bill?

@jonasholtkamp
Copy link

Or at least a keystroke that is located farther away from other combinations 😁

@Jonathan34
Copy link

CTRL+SHIFT+D Or Delete?

@matthyx
Copy link
Author

matthyx commented Feb 6, 2019

Delete key, please!

@derailed
Copy link
Owner

derailed commented Feb 6, 2019

Thank you all for sharing. Getting ready to drop a new rev. Changed to key as suggested here. v0.1.2 coming soon...

@derailed derailed added the enhancement New feature or request label Feb 6, 2019
@matthyx
Copy link
Author

matthyx commented Feb 7, 2019

Fixed in 0.1.2
Thanks @derailed !

@matthyx matthyx closed this as completed Feb 7, 2019
@matthyx
Copy link
Author

matthyx commented Feb 7, 2019

BTW, is it Delete or Backspace?

@Jancis
Copy link

Jancis commented Feb 7, 2019

I deleted couple machines because i was trying to delete mistyped characters in filter. I could use some confirmation prompt,.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

5 participants