Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature request: render ANSI colors in log files #29

Closed
thomasjm opened this issue Feb 7, 2019 · 7 comments
Closed

Feature request: render ANSI colors in log files #29

thomasjm opened this issue Feb 7, 2019 · 7 comments
Labels
enhancement New feature or request

Comments

@thomasjm
Copy link

thomasjm commented Feb 7, 2019

It would be really slick if k9s could interpret ANSI escape sequences and show colors, I find colors make logs easier to read.
@derailed
Copy link
Owner

derailed commented Feb 7, 2019

We do have color logging. Think I've changed it after the initial drop. Do you have something else in mind?

@derailed derailed added the enhancement New feature or request label Feb 7, 2019
@thomasjm
Copy link
Author

thomasjm commented Feb 7, 2019

Hmm, I just tried release 0.1.2 and it doesn't seem to work. The log output is all yellow colored. Are you sure k9s is handling ANSI escape codes? To be clear I'm talking about these

@derailed
Copy link
Owner

derailed commented Mar 1, 2019

Fixed 0.2.0!

@derailed derailed closed this as completed Mar 1, 2019
@thomasjm
Copy link
Author

thomasjm commented Mar 3, 2019

@derailed this should be re-opened right? Looks like it was attempted in 0.2.0 and reverted in 0.2.1.

@derailed
Copy link
Owner

derailed commented Mar 3, 2019

Right! Thanks @thomasjm.

@derailed derailed reopened this Mar 3, 2019
@derailed
Copy link
Owner

@thomasjm Fixed 0.2.2!

@thomasjm
Copy link
Author

Sweet, looks good!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@derailed @thomasjm