Skip to content
This repository has been archived by the owner on Apr 18, 2023. It is now read-only.

Song-change notifications display album rather than song title #21

Closed
derat opened this issue Sep 17, 2021 · 0 comments
Closed

Song-change notifications display album rather than song title #21

derat opened this issue Sep 17, 2021 · 0 comments
Assignees
Labels
bug Something isn't working

Comments

@derat
Copy link
Owner

derat commented Sep 17, 2021

music-player.js does the following:

      const options = { body: `${song.album}\n${formatTime(song.length)}` };
      if (song.coverFilename) {
        options.icon = getScaledCoverUrl(song.coverFilename);
      }
      this.notification_ = new Notification(
        `${song.artist}\n${song.title}`,
        options
      );

At least as of Chrome 93, it looks like multiline titles get elided, so the notification ends up like this instead:

Screenshot 2021-09-17 13 12 45

@derat derat added the bug Something isn't working label Sep 17, 2021
@derat derat self-assigned this Sep 17, 2021
@derat derat closed this as completed in 38c7be9 Oct 1, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant