Skip to content
This repository has been archived by the owner on Apr 18, 2023. It is now read-only.

Merging songs can result in duplicate tags #33

Closed
derat opened this issue Feb 9, 2022 · 0 comments
Closed

Merging songs can result in duplicate tags #33

derat opened this issue Feb 9, 2022 · 0 comments
Assignees
Labels
bug Something isn't working

Comments

@derat
Copy link
Owner

derat commented Feb 9, 2022

Ugh, I just noticed that tags can be duplicated when using nup update -merge-songs, e.g.

  "tags": [
    "drums",
    "drums",
    "electronic",
    "hip-hop",
    "hip-hop",
    "nonsensical-lyrics",
    "silly",
    "silly",
    "tense",
    "tense",
    "vocals",
    "vocals"
  ]

Both the server and the client should be preventing this from happening. Hopefully I just broke it with a5f1612's "ill-advised refactoring".

@derat derat added the bug Something isn't working label Feb 9, 2022
@derat derat self-assigned this Feb 9, 2022
@derat derat closed this as completed in 8fb007d Feb 9, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant