Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

urllib -> requests #115

Open
derek-adair opened this issue Apr 24, 2020 · 2 comments
Open

urllib -> requests #115

derek-adair opened this issue Apr 24, 2020 · 2 comments

Comments

@derek-adair
Copy link
Owner

There is a mish-mash of various request libraries used here. I plan on just swapping them all to requests

@xabrickx
Copy link

xabrickx commented May 9, 2020

Hey, I'm new to this project and interested in picking this up.

I've "done" the change here
master...xabrickx:update/115_normalize_requests
but didn't want throw PR at you without saying any thing. My change creates simple wrappers for request/response and reroutes the current requests, including the lingering urllib requests, through them.

I'm happy to simplify this and ditch the wrapper if you prefer but thought the benefits of standardizing the requests would outweigh the additional complexity. Please let me know if I've missed anything or you have any recommendations?

@derek-adair
Copy link
Owner Author

derek-adair commented May 9, 2020

My change creates simple wrappers for request/response and reroutes the current requests,

Most excellent, this needed doing anyways considering the user-agent string requirement. I'll be looking over this but at a glance it looks very solid.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants