Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove hard coded team object in __init__.py #24

Closed
derek-adair opened this issue Sep 3, 2018 · 2 comments
Closed

Remove hard coded team object in __init__.py #24

derek-adair opened this issue Sep 3, 2018 · 2 comments

Comments

@derek-adair
Copy link
Owner

A dicitonary of the various ways to refer to a team is stored in init.py

This seems odd and clunkyy. I think the team objects should be deduced so we dont have to update it if/when a team moves.

I am unsure of what side effects this has and it is probably not even worth doing xD

@derek-adair
Copy link
Owner Author

derek-adair commented Sep 3, 2018

For example, JAX vs JAC for the jaguars. This is the only team formatted in this way where the abbreviation the nfl api returns is not the first slot in the array.

@derek-adair
Copy link
Owner Author

Ugh this is not possible without breaking update_schedule. This is used to look up historic data.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant