Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keep reminders when updating events #299

Closed
jordanbtucker opened this issue Jan 7, 2023 · 2 comments
Closed

Keep reminders when updating events #299

jordanbtucker opened this issue Jan 7, 2023 · 2 comments
Labels
enhancement New feature or request

Comments

@jordanbtucker
Copy link

When an event is updated, it does not retain any reminders previously added to it.

For example:

  1. Sync an ICS with a Google Calendar.
  2. Add a reminder to an event.
  3. Sync the ICS again after that event was changed in the ICS.
  4. Note that the event in the Google Calendar has its reminders removed.

I'd like to request a feature where reminders added to a Google Calendar event stay with that event even after being updated by a sync. This likely only makes sense when addAlerts is set to false.

@jordanbtucker jordanbtucker added the enhancement New feature or request label Jan 7, 2023
@jonas0b1011001
Copy link
Collaborator

jonas0b1011001 commented Jan 7, 2023

In Helpers.gs:

  • in line 222 replace Calendar.Events.update with Calendar.Events.patch

  • comment out/remove lines 389-394 and (if you have it) lines 424-427.

Sync with addAlerts = false.
Let me know if that's the behavior you are looking for.

@jordanbtucker
Copy link
Author

@jonas0b1011001 Thanks. I already did something similar that worked.

I added the following line between lines 221 and 222 and set addAlerts to false.

newEvent.reminders = calendarEvents[index].reminders;

This is a little more narrow in scope than patch because I was just targeting reminders. But I could see how it could be useful to patch the event to maintain any other information added to an event that isn't in the ICS, not just reminders.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants