Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multi calendar #9

Closed
wants to merge 2 commits into from
Closed

Multi calendar #9

wants to merge 2 commits into from

Conversation

agentd00nut
Copy link
Collaborator

Takes relatively little code to make this happen surprisingly.

Currently does nothing to alleviate the issues i've faced with going over API quotas or execution times

@agentd00nut
Copy link
Collaborator Author

#6

Code.gs Outdated
@@ -12,12 +12,15 @@
// var targetCalendarName = "" // The name of the Google Calendar you want to add events to
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we're going to deprecate targetCalendarName and sourceCalendarURL, let's just remove those options

Code.gs Outdated

var sourceCalendars={
CustomName:"ICS/ICAL URL"
}
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rather than having sourceCalendars "prepopulated" with example data, let's leave it blank (like you did before with var sourceCalendars = { }; ) and put a comment before explaining how it should be used (even use a block comment if you need to)



// Currently global settings are applied to all sourceCalendars.

var howFrequent = 15; //What interval (minutes) to run this script on to check for new events
var howFrequent = 30; //What interval (minutes) to run this script on to check for new events
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is this being changed again? Leftover from testing?

@@ -156,6 +170,7 @@ function main(){
//----------------------------------------------------------------

if(addEventsToCalendar || removeEventsFromCalendar){
/* We might want to consider reducing how far back we reach for events to reduce API call usage... Also would make a good premium feature */
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point, but let's take this comment out so we don't have comments about "possible premium features" in our code :)

@derekantrican
Copy link
Owner

derekantrican commented Feb 11, 2019

@agentd00nut Note that this branch will have to be redone since PR #20

@agroszer
Copy link

agroszer commented Mar 4, 2019

any chance to get this up to speed?

derekantrican pushed a commit that referenced this pull request Oct 16, 2019
Added MD5 Checksum to determine if an event was updated. (Fix #3)
Code cleanup and reorganization.
No longer set iCalUID for new events, id will be saved as extended property
@derekantrican
Copy link
Owner

Closing this PR as we have multi calendar support in the next version

@derekantrican derekantrican deleted the MultiCalendar branch November 1, 2019 19:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants