Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

facebook require full url in href iframe #23

Merged
merged 1 commit into from Nov 4, 2017
Merged

facebook require full url in href iframe #23

merged 1 commit into from Nov 4, 2017

Conversation

Erwane
Copy link
Contributor

@Erwane Erwane commented Nov 3, 2017

iframe src for facebook require now the full url :

https://www.facebook.com/plugins/video.php?href=https://www.facebook.com/CenterforBioDiv/videos/10155664753620460/

@Erwane
Copy link
Contributor Author

Erwane commented Nov 3, 2017

Sorry for unittest and coverage, got that error when trying to test

PHP Fatal error:  Class 'PHPUnit_Framework_TestCase' not found in /data/www/project-test/vendor/dereuromark/media-embed/tests/MediaEmbed/MediaEmbedTest.php on line 8

@dereuromark dereuromark merged commit 710e109 into dereuromark:master Nov 4, 2017
@Erwane Erwane deleted the 18-facebook-url branch November 4, 2017 16:27
@Erwane Erwane mentioned this pull request Nov 4, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants