given/when/smartmatch deprecation warnings

[gregoa]

In perl 5.38, the warning about given/when/smartmatch were moved from the experimental category to the new deprecated category. While the code suppress the former warnings:

bin/efa:no if $] >= 5.018, warnings => 'experimental::smartmatch';
lib/Travel/Routing/DE/EFA.pm:no if $] >= 5.018, warnings => "experimental::smartmatch";
lib/Travel/Routing/DE/VRR.pm:no if $] >= 5.018, warnings => "experimental::smartmatch";

the latter now show up, e.g. when running the test suite under 5.38:

given is deprecated at /build/libtravel-routing-de-vrr-perl-2.21/blib/lib/Travel/Routing/DE/EFA.pm line 179.
when is deprecated at /build/libtravel-routing-de-vrr-perl-2.21/blib/lib/Travel/Routing/DE/EFA.pm line 180.
when is deprecated at /build/libtravel-routing-de-vrr-perl-2.21/blib/lib/Travel/Routing/DE/EFA.pm line 181.
when is deprecated at /build/libtravel-routing-de-vrr-perl-2.21/blib/lib/Travel/Routing/DE/EFA.pm line 182.
given is deprecated at /build/libtravel-routing-de-vrr-perl-2.21/blib/lib/Travel/Routing/DE/EFA.pm line 198.
when is deprecated at /build/libtravel-routing-de-vrr-perl-2.21/blib/lib/Travel/Routing/DE/EFA.pm line 199.
when is deprecated at /build/libtravel-routing-de-vrr-perl-2.21/blib/lib/Travel/Routing/DE/EFA.pm line 200.
when is deprecated at /build/libtravel-routing-de-vrr-perl-2.21/blib/lib/Travel/Routing/DE/EFA.pm line 201.
Smartmatch is deprecated at /build/libtravel-routing-de-vrr-perl-2.21/blib/lib/Travel/Routing/DE/EFA.pm line 232.
Smartmatch is deprecated at /build/libtravel-routing-de-vrr-perl-2.21/blib/lib/Travel/Routing/DE/EFA.pm line 308.
Smartmatch is deprecated at /build/libtravel-routing-de-vrr-perl-2.21/blib/lib/Travel/Routing/DE/EFA.pm line 731.

Now one option would be to suppress the new warnings as well, e.g.

no if $] >= 5.017011, warnings => 'experimental::smartmatch';
no if $] >= 5.037010, warnings => 'deprecated::smartmatch';

but given the announcement that given/when/smartmatch is to be removed in 5.42, a rewrite of the affected code might be better in the long run.

Cheers,
gregor

[derf]

Indeed. Thanks for pointing it out!

[gregoa]

On Thu, 31 Aug 2023 22:19:44 -0700, Birte Friesel wrote: Indeed. Thanks for pointing it out!

Thanks to you for the quick fix & release! Cheers, gregor

…

-- .''`. https://info.comodo.priv.at -- Debian Developer https://www.debian.org : :' : OpenPGP fingerprint D1E1 316E 93A7 60A8 104D 85FA BB3A 6801 8649 AA06 `. `' Member VIBE!AT & SPI Inc. -- Supporter Free Software Foundation Europe `-