Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

create a command line lib for any HAFAS client #5

Closed
sixtyfive opened this issue Nov 7, 2016 · 10 comments
Closed

create a command line lib for any HAFAS client #5

sixtyfive opened this issue Nov 7, 2016 · 10 comments

Comments

@sixtyfive
Copy link

What an awesomething. How about adding Deutsche Bahn?

@derhuerst
Copy link
Owner

What an awesomething.

Thanks!

How about adding Deutsche Bahn?

Deutsche Bahn data includes urban public transport, but in a really inaccurate way. Also, those two datasets are hard to bring together, since they have different IDs, names, etc.

Getting something like vbb-cli for DB would work like this:

  1. use db-hafas to query the data
  2. adapt vbb-rest to make a REST API
  3. adapt vbb-client to fetch from the REST API
  4. adapt vbb-cli for get a command line client

2 and 3 are optional, as db-cli could use db-hafas directly (having a REST API just makes the client more lightweight).

@derhuerst
Copy link
Owner

Recently, VBB (urban transport for Berlin) switched to international IDs for the static data and they plan to switch for their API, so hopefully, we'll be able to bring these two together soon!

I'm working on making all my modules compatible with the new IDs, but it takes time.

@sixtyfive
Copy link
Author

That sounds like awesome news! Sorry that I couldn't do more than open the FR; live just doesn't permit me any side projects atm. May it grant you a little time here and there! 😄

@derhuerst
Copy link
Owner

I adapted all modules and fixed all the bugs i could find. still, i don't have too much time, but looking more into Deutsche Bahn and other contries with HAFAS would be interesting. @juliuste might also be interested

@hammer065
Copy link

I know several people who would be interested if more cities/regions will be supported.
Also I never noticed any discrepancy between the reality and what the DB-API tells me regarding to urban public transport

@derhuerst
Copy link
Owner

@hammer065 Writing a separate DB command line client would be entirely possible. But merging both data sources into one client seems infeasible right now.

@hammer065
Copy link

@derhuerst A separate db-client would be entirely fine though.
You could use vbb-cli to to develop a standard public transport cli, where you can choose which system you wanna use (vbb, DB, etc.).
This could make the system even more modular.

@derhuerst
Copy link
Owner

You could use vbb-cli to to develop a standard public transport cli, where you can choose which system you wanna use (vbb, DB, etc.).

Not sure this is necessary. Also not sure if people want to install all the dependencies for all public transport agencies only to be able to choose at runtime.

@derhuerst
Copy link
Owner

see also #9.

@derhuerst derhuerst changed the title FR: More cities puhleeeese! Heck, whole countries! create a command line lib for any HAFAS client Feb 6, 2018
@derhuerst
Copy link
Owner

Done. hafas-cli contains the general logic to expose a hafas-client@3-compatible API as a command line interface.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants