Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds io.vavr support, fixing #71 #75

Merged
merged 2 commits into from Jun 6, 2017
Merged

Adds io.vavr support, fixing #71 #75

merged 2 commits into from Jun 6, 2017

Conversation

talios
Copy link
Contributor

@talios talios commented Jun 6, 2017

Adds new Vavr flavour and adds the related mappings.

I'm not overly familiar with Gradle so havn't tested this against my maven projects yet. Can one easily deploy the equivalent of a -SNAPSHOT into the local repo?

@codecov-io
Copy link

codecov-io commented Jun 6, 2017

Codecov Report

Merging #75 into master will increase coverage by 0.14%.
The diff coverage is 66.66%.

Impacted file tree graph

@@             Coverage Diff             @@
##             master     #75      +/-   ##
===========================================
+ Coverage      5.45%   5.59%   +0.14%     
  Complexity       39      39              
===========================================
  Files            55      55              
  Lines          2604    2610       +6     
  Branches        143     143              
===========================================
+ Hits            142     146       +4     
- Misses         2457    2459       +2     
  Partials          5       5
Impacted Files Coverage Δ Complexity Δ
annotation/src/main/java/org/derive4j/Flavour.java 0% <0%> (ø) 0 <0> (ø) ⬇️
...n/java/org/derive4j/processor/DeriveUtilsImpl.java 20.92% <100%> (+0.77%) 21 <0> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3b6d687...734637d. Read the comment docs.

@jbgi
Copy link
Member

jbgi commented Jun 6, 2017

Thanks, looks good!
I think you can install into local maven repo with ./gradlew install.
btw, I forgot to increment the version after last release. Could you do it as part of the PR, setting it to "0.12.3" at https://github.com/derive4j/derive4j/blob/master/build.gradle#L43 ?
Then you can test using version 0.12.3-SNAPSHOT.

@talios
Copy link
Contributor Author

talios commented Jun 6, 2017

Interesting - everything is being generated with a trailing 0 on the constructor methods. Is that something new in derive4j somewhere?

@talios
Copy link
Contributor Author

talios commented Jun 6, 2017

Hrm, my class had value = @Derive(withVisibility = Visibility.Smart) which made all the constructors end with 0. Odd.

@jbgi
Copy link
Member

jbgi commented Jun 6, 2017

@talios normally that is the case only if you use "Smart" visibility, and it is not new.

@talios
Copy link
Contributor Author

talios commented Jun 6, 2017

@jbgi Ah ok - it's been awhile since I've had time to work on this codebase ( quite a while ). In that case, without it I see things working fine.

@jbgi jbgi merged commit 9a8ee06 into derive4j:master Jun 6, 2017
@talios talios deleted the vavr branch June 6, 2017 11:10
@jbgi jbgi added this to the 0.12.3 milestone Jun 6, 2017
@jbgi
Copy link
Member

jbgi commented Jun 6, 2017

0.12.3 is on its way to maven central (if not already there).
Thanks!

@talios
Copy link
Contributor Author

talios commented Jun 6, 2017

Excellent! Time for bed here so will check it out in the morning!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants