Limit progress update to fix 100% cpu, larger buffer and show speed per chunk #41
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k0pernicus
approved these changes
Jan 22, 2017
| use response::CheckResponseStatus; | ||
| use std::cmp::min; | ||
| use std::io::Read; | ||
| use std::thread; | ||
| use std::time::{Instant, Duration}; | ||
|
|
||
| const DOWNLOAD_BUFFER_BYTES: usize = 1024*64; |
There was a problem hiding this comment.
Just add a single comment to explain why you multiply a buffer size (1024) by 64, please :-)
There was a problem hiding this comment.
A larger buffer means less context switches between the kernel and the snatch process.
The multiplication is just to it's clear that it is 64KiB.
2048byte buffer means 5120 loops per second on 10MiB/s
64KiB is 81 loops in the best case.
There are also Disk seek times on HDD and page sizes on SSDs to consider.
| let mut sum_bytes = 0; | ||
|
|
||
| let progress_update_interval = Duration::from_millis(500); |
There was a problem hiding this comment.
Maybe you can extract the 500 value in a constant (like REFRESH_DURATION) - it would be nice if we need to update this one later.
|
Thanks a lot 👍 |
|
Oh god, u32 is wrong :( it must be u64. |
|
No problem - I fixed the issue ;-) |
|
Thanks :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was trying to make a constant for the interval duration, but it does not seem possible to create a
Durationin a static/const becauseDurationfields are private and calls are not permitted in const/static expressions.CPU usage is way down with the 500ms progress update interval.