Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

getComments() accepts number or string key #44

Closed
derrell opened this issue Jul 21, 2011 · 1 comment
Closed

getComments() accepts number or string key #44

derrell opened this issue Jul 21, 2011 · 1 comment
Assignees
@derrell

Comments

@derrell
Copy link
Owner

derrell commented Jul 21, 2011

Passing either 105 or "105" to the getComments() function provides the correct results. It probably shouldn't. The actual appId (key) is 105.

This should be looked at as a general issue rearing its head in getComments(), but likely of much wider scope.
@ghost ghost assigned derrell Jul 21, 2011
@derrell derrell closed this as completed Jul 31, 2011
@derrell derrell reopened this Jul 31, 2011
@derrell
Copy link
Owner Author

derrell commented Jul 31, 2011

This was, in fact, a general issue. Fixed in the sim.Dbif in qooxdoo-contrib, with r21367. Also added a test case for it in CommentTest.

@derrell derrell closed this as completed Jul 31, 2011
derrell added a commit that referenced this issue Jul 31, 2011
@derrell
#44 test. Fixed in sim/Dbif.
ded0d8e
derrell added a commit that referenced this issue Jul 31, 2011
@derrell
#44 test. Fixed in sim/Dbif.
728794f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@derrell derrell

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@derrell