Problems with addComments

[mbenn112]

There is a bug in the addComments code. I can add comments and get them back when I first open an application. Closing and opening the app tag without refreshing the browser does not affect addComments. However, after you refresh the browser, addComments starts to reuse comment uid's, effectively overwriting the ones which were previously added.

Also, in the data returned in getAppInfo, there is numComments and numRootComments. numRootComments appears to be accurately counting the number of comments added, even though some have been overwritten by addComments. numComments, however, always remains at zero.

[derrell]

Mary, please see my note to you regarding your pull request. Your MComments.js is not what's in wip. It has significant formatting differences, so I have no idea what else is different. Reed has done a lot of work on MComments recently, so you have to have his latest code. I provided some suggestions to you in my email, for how to most easily recover everything other than your three files back to the state in wip.

I'll close this bug for now. If you still have problems in latest wip, please re-open it.

Derrell

[reedspool]

The errors you describe, Mary, are perfectly accurate. I will have these functionalities fixed today.

[derrell]

On Wed, Jul 27, 2011 at 13:55, reedspool <
reply@reply.github.com>wrote:

The errors you describe, Mary, are perfectly accurate. I will have these
functionalities fixed today.

Actually, I think that's all fixed now. Let's talk at the meeting.

I'm having troubles with addComments in the appengine environment, though.
I'll discuss that too, in a few minutes.

[reedspool]

The numComments of an App is not being properly managed in MComments.js, either on the addition of a comment or on deletion.

[derrell]

@mbenn112 please let me and @reedspool know if this problem is now fixed.

[mbenn112]

The problem with addComments is fixed.