Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

command 'legendary status' fails with error-dump messages when not authenticated #106

Closed
krdh opened this issue Sep 27, 2020 · 0 comments
Closed

Comments

@krdh
Copy link

krdh commented Sep 27, 2020

Small issue I bumped into as a new user :
First time ever(new install) of the "AUR legendary 0.20.1-1" on Manjaro .
The first command I typed in the terminal was legendary status which gave an unclear error, see below.
`> legendary status

Traceback (most recent call last):
File "/usr/bin/legendary", line 33, in sys.exit(load_entry_point('legendary-gl==0.20.1', 'console_scripts', 'legendary')())
File "/usr/lib/python3.8/site-packages/legendary/cli.py", line 1304, in main cli.status(args)
File "/usr/lib/python3.8/site-packages/legendary/cli.py", line 1005, in status games_available = len(self.core.get_game_list(update_assets=not args.offline))
File "/usr/lib/python3.8/site-packages/legendary/core.py", line 222, in get_game_list return self.get_game_and_dlc_list(update_assets=update_assets)[0]
File "/usr/lib/python3.8/site-packages/legendary/core.py", line 232, in get_game_and_dlc_list for ga in self.get_assets(update_assets=update_assets,
File "/usr/lib/python3.8/site-packages/legendary/core.py", line 200, in get_assets self.lgd.assets = [GameAsset.from_egs_json(a) for a in self.egs.get_game_assets()]
File "/usr/lib/python3.8/site-packages/legendary/api/egs.py", line 101, in get_game_assets r.raise_for_status()
File "/usr/lib/python3.8/site-packages/requests/models.py", line 941, in raise_for_status raise HTTPError(http_error_msg, response=self)
requests.exceptions.HTTPError: 401 Client Error: Unauthorized for url: https://launcher-public-service-prod06.ol.epicgames.com/launcher/api/public/assets/Windows?label=Live
`
After authenticating, the command legendary status gave nice clean reply.

So it would be nice to prevent the unclear error (dump), and give a clean error message.

hope I helped, Many thanks for your efforts ...

@derrod derrod closed this as completed in e979413 Nov 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant