Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update counts as successful even if DLManager runs into an error. #615

Open
itsTyrion opened this issue Oct 18, 2023 · 4 comments
Open

Update counts as successful even if DLManager runs into an error. #615

itsTyrion opened this issue Oct 18, 2023 · 4 comments

Comments

@itsTyrion
Copy link

itsTyrion commented Oct 18, 2023

Platform

Operating system and version: Win 10 21H2
Legendary version (legendary -V): legendary version "0.20.33", codename "Undue Alarm"

Expected Behavior

-

Current Behavior

image

In this case, the DLManager immediately crashed because it couldn't allocate the required memory (I had lots of stuff open).
However, Legendary still counted it as success: [cli] INFO: Finished installation process in 0.57 seconds. and bumped the version number, leaving the game not playable because outdated but not update-able because it's deemed up-to-date.

Steps to Reproduce

  1. Get the DLManager to throw/experience an error during an update
  2. Retry to update.

Additional information

-

@nutterthanos
Copy link

You would think it would know that your paging file is not big enough beforehand

@itsTyrion
Copy link
Author

It happened again so it wasn't a fluke

@itsTyrion
Copy link
Author

itsTyrion commented Jan 27, 2024

happened again with legendary version "0.20.34", codename "Direct Intervention"
RAM was on 89%, "Commited" (task-manager) on 30/33.4 so it should've been fine.

I was able to work around it by deleting the latest .manifest, then changing the version in metadata/Fortnite.json and installed.json to the previous one (taken from the old manifest files since it wasn't deleted), then updating after closing something

@nutterthanos
Copy link

happened again with legendary version "0.20.34", codename "Direct Intervention" RAM was on 89%, "Commited" (task-manager) on 30/33.4 so it should've been fine.

I was able to work around it by deleting the latest .manifest, then changing the version in metadata/Fortnite.json and installed.json to the previous one (taken from the old manifest files since it wasn't deleted), then updating after closing something

weird

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants