Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix an issue in the Update script #17

Closed
Derroylo opened this issue Sep 7, 2023 · 1 comment · Fixed by #19
Closed

Fix an issue in the Update script #17

Derroylo opened this issue Sep 7, 2023 · 1 comment · Fixed by #19
Assignees
Labels
bug Something isn't working
Milestone

Comments

@Derroylo
Copy link
Owner

Derroylo commented Sep 7, 2023

The update script checks the wrong location for the update folder, so gpt downloads the update but it will not be applied.

# Check if the update folder exists
if [ -d "update" ]; then
    cd $GPTDIR

    # Move all files from the update folder to the current one and remove it afterwards
    mv update/* .

    # Remove the update folder
    rm -rf update

    # Set execution rights for the shell script
    chmod +x gpt.sh
fi

but it should be

# Check if the update folder exists
if [ -d "$GPTDIR/update" ]; then
    cd $GPTDIR

    # Move all files from the update folder to the current one and remove it afterwards
    mv update/* .

    # Remove the update folder
    rm -rf update

    # Set execution rights for the shell script
    chmod +x gpt.sh
fi
@Derroylo Derroylo added the bug Something isn't working label Sep 7, 2023
@Derroylo Derroylo added this to the v0.4.1 milestone Sep 7, 2023
@Derroylo Derroylo self-assigned this Sep 7, 2023
@Derroylo Derroylo linked a pull request Sep 7, 2023 that will close this issue
@Derroylo
Copy link
Owner Author

Derroylo commented Sep 8, 2023

Has been fixed with the linked PR

@Derroylo Derroylo closed this as completed Sep 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

1 participant