Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Running examples from the test suite #13

Closed
robmoss opened this issue Feb 27, 2024 · 2 comments
Closed

Running examples from the test suite #13

robmoss opened this issue Feb 27, 2024 · 2 comments

Comments

@robmoss
Copy link

robmoss commented Feb 27, 2024

I've successfully run the trivial, highdim, and adaan examples, and have a few questions and comments:

  • I discovered how to run fewer iterations by looking at the source code and .github/workflows/test_publish_pypi.yml, but it might be helpful to point out somewhere that this can be controlled by setting the it environment variable.
  • The adaan example appeared to run for more than the specified number of iterations? For example, with it=100 it looked to run 370 iterations, and with it=1000 it looked to run 1270 iterations. Have I misinterpreted the output messages?
  • When the number of iterations is less than exp.save_interval, no outputs are saved. It could be useful to always save outputs at the end of the experiment, in addition to doing so at every save interval?
@daneschi
Copy link
Member

Thank you for the comments:

  • I have added some comments to the readme file to include the "it" option if the user would like to run the tests for a custom number of iterations.
  • If adaptive annealing is active then "it" is interpreted as the number of iterations at temperature=1.0, i.e., approximating the actual posterior distribution, instead of its annealed substitute. As a result, the total number of iterations is greater than "it", i.e., "it" plus all the iterations for a temperature <1.0.
  • I have changed the code in "run_experiment.py" so the results at the last iterations are always saved.

Thanks Again for looking in this!

@robmoss
Copy link
Author

robmoss commented Mar 12, 2024

Thanks very much for explaining the number of iterations, that was really helpful :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants