Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support Django 2.0 and 2.1 #472

Closed
uri-rodberg opened this issue Jul 4, 2018 · 11 comments
Closed

Support Django 2.0 and 2.1 #472

uri-rodberg opened this issue Jul 4, 2018 · 11 comments
Assignees
@last-partizan

Comments

@uri-rodberg
Copy link

uri-rodberg commented Jul 4, 2018 •
edited

When will you release a stable (not beta) release supporting Django 2.0? django-modeltranslation is one of only 2 packages in our project (https://github.com/speedy-net/speedy-net) not supporting Django 2.0 with stable releases (the other one is django-friendship, which released a version supporting Django 2.0, but it has bugs/issues).
uri-rodberg referenced this issue in speedy-net/speedy-net Jul 4, 2018
@uri-rodberg
- Upgraded requirements (currently all are latest except Django and d…
510bf95 
…jango-friendship).

- To upgrade all the requirements (with Django>=1.11,<2.0 and django-friendship==1.5.0), run:
pip install --upgrade -r requirements-pip-upgrade.txt
- To upgrade all the requirements (including Django and django-friendship), run:
pip install --upgrade -r requirements-without-versions.txt
(notice that django-modeltranslation and django-friendship latest stable releases still don't support Django 2.0, or have bugs/issues).
@uri-rodberg
Copy link
Author

Currently django-modeltranslation is the only package in our project not supporting Django 2.0 with a stable release (django-friendship released a new version supporting Django 2.0 without known bugs/issues).

@last-partizan
Copy link
Collaborator

Any news on this?

@karolyi
Copy link

karolyi commented Sep 5, 2018

refers #467

@mhaehnel mhaehnel mentioned this issue Sep 21, 2018
Closed
@pypetey
Copy link

pypetey commented Sep 23, 2018 •
edited

Any updates on this one? What can be done to have final version released?

@raratiru raratiru mentioned this issue Oct 16, 2018
Closed
karolyi referenced this issue in django/django Oct 23, 2018
@timgraham
Refs #28814 -- Fixed "SyntaxError: Generator expression must be paren…
931c60c 
…thesized" on Python 3.7.

Due to https://bugs.python.org/issue32012.
@lifenautjoe
Copy link

lifenautjoe commented Dec 21, 2018 •
edited

Tried installing the beta. Admin does not work.

pipenv install -e git+https://github.com/deschler/django-modeltranslation.git@0.13-beta1#egg=django-modeltranslation

@ulgens
Copy link

ulgens commented Dec 27, 2018

@deschler Is everything okay there? 🙂

@uri-rodberg
Copy link
Author

Django 2.0 was released on December 2017, and Django 2.1 on August 2018, so I think it's about time for django-modeltranslation to support them.

@uri-rodberg uri-rodberg changed the title Support Django 2.0 Support Django 2.0 and 2.1 Dec 27, 2018
@lifenautjoe
Copy link

Hi @deschler , everything alright there mate? 🙏

@uri-rodberg uri-rodberg mentioned this issue Jan 5, 2019
Closed
@gabn88
Copy link

gabn88 commented Jan 26, 2019 •
edited

Hi @deschler, hope you are alright and thanks for creating this fine package. We have used it for several years without any real issues. Many thanks for that.

Due to lack of maintenance of this package and the need to upgrade to Django 2.0+, and use of features that this package does not support (such as certain queries), I have upgraded our staging server to django-translated-fields. I am not familiar with the author, but the package is only 50 lines and therefore very understandable. It is also very basic, but with some glue code (for example like I wrote down here here), we were able to make the switch fairly quick. Added bonus is that all advanced queries are working now. We are still testing, but it looks promising!

@raratiru
Copy link

raratiru commented Feb 9, 2019

Thank you @gabn88 this is very relieving.

@last-partizan last-partizan self-assigned this Feb 11, 2019
@last-partizan
Copy link
Collaborator

Closing this issue.

Django 2.0 and 2.1 is supported in master, planning to release beta in few days, final next week.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@last-partizan last-partizan

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
8 participants
@ulgens @last-partizan @karolyi @pypetey @raratiru @gabn88 @lifenautjoe @uri-rodberg