Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check for famous sliders #31

Open
EugenioPetulla opened this issue Mar 1, 2016 · 2 comments
Open

Check for famous sliders #31

EugenioPetulla opened this issue Mar 1, 2016 · 2 comments

Comments

@EugenioPetulla
Copy link
Collaborator

EugenioPetulla commented Mar 1, 2016

Add a check for most popular slider plugins and disable the pin button function.

This could be achieved easily but we have to find a list of the most popular slider and/or carousel plugins.

Anyone want help? @deshack :P

--- Want to back this issue? **[Post a bounty on it!](https://www.bountysource.com/issues/31466466-check-for-famous-sliders?utm_campaign=plugin&utm_content=tracker%2F5008995&utm_medium=issues&utm_source=github)** We accept bounties via [Bountysource](https://www.bountysource.com/?utm_campaign=plugin&utm_content=tracker%2F5008995&utm_medium=issues&utm_source=github).
@deshack
Copy link
Owner

deshack commented Mar 4, 2016

Master Slider, Slick Slider, Nivo Slider, Meta Slider, Huge-IT Slider, Soliloquy, Meteor Slides, Cyclone Slider, FlexSlider, Smooth Slider.

I would also look at popular front-end frameworks carousels, at least Bootstrap's and Foundation's.

@EugenioPetulla
Copy link
Collaborator Author

It's not very easy to detect a js script, like bootstrap or foundation carousels. If they change name of the script or just if they load the script on every pages instead of doing a smart loading this will became a nightmare soon.

So I propose to detect only plugins and do not mess with other kind of "not WordPress directly related" code.

Otherwise we have to support owl carousel (one of the most popular, also more popular then bootstrap too, especially in woocommerce templates), slick and the orrible jssor (loved from a lot of old web-designer of old mindset website) :P

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants