Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for Jupyter Lab 3.1.x #50

Closed
bschulth opened this issue Sep 1, 2021 · 7 comments
Closed

Support for Jupyter Lab 3.1.x #50

bschulth opened this issue Sep 1, 2021 · 7 comments

Comments

@bschulth
Copy link

bschulth commented Sep 1, 2021

Would be great to add support for Jupyter Lab 3.1.x ?

https://github.com/deshaw/jupyterlab-execute-time/blob/master/package.json#L59-L64

https://jupyterlab.readthedocs.io/en/stable/getting_started/changelog.html#v3-1

Thanks!

@mlucool
Copy link
Member

mlucool commented Sep 1, 2021

This should work if you install it with the new directions: https://github.com/deshaw/jupyterlab-execute-time#install

@ZeyuSun
Copy link

ZeyuSun commented Sep 1, 2021

The new direction says pip install jupyterlab_execute_time but I don't think it is working on my environment:

jupyterlab                    3.1.9
jupyterlab-execute-time       2.0.2

I didn't try to install with conda because it takes forever to solve environment.

@mlucool
Copy link
Member

mlucool commented Sep 4, 2021

Did you enable recordTiming?

@ZeyuSun
Copy link

ZeyuSun commented Sep 5, 2021

Yes, I did. It's something else that is going wrong in my environment. I created a new one and it worked.

@Tabixe
Copy link

Tabixe commented Sep 21, 2021

I was having this issue when trying to install the extension directly on the JupyterLab interface but the conda command worked smoothly. Thanks for this great tool!

@bschulth
Copy link
Author

@mlucool, I can confirm this works if you install via pip:

# Works
/usr/bin/pip install jupyterlab-execute-time
jupyter lab build --log-level=DEBUG
jupyter labextension list

It fails when you try to install via jupyter labextension

# Fails
jupyter labextension install --no-build jupyterlab-execute-time
jupyter lab build --log-level=DEBUG
jupyter labextension list

And yes, @mlucool, I was already aware of the setting requirement:

  • Settings- > Advanced Settings Editor -> Notebook: {"recordTiming": true}

Close the issue?

  • I am happy to mark this issue closed, given that it works via pip install.

@sg-s
Copy link

sg-s commented Sep 28, 2021

@bschulth thanks, this works for me.

however, when i did this, something else broke, and i had to fix that using this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants