Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure the form is validated while creating a kernelspec #61

Open
echarles opened this issue Aug 27, 2021 · 0 comments
Open

Ensure the form is validated while creating a kernelspec #61

echarles opened this issue Aug 27, 2021 · 0 comments

Comments

@echarles
Copy link
Contributor

echarles commented Aug 27, 2021

For now, we hide the standard react-json-form button to only display the JupyterLab buttons

https://github.com/Quansight/ksmm/blob/9d92b59f12f432dd5c78c6b9d5e511e128b01f0a/src/widget.tsx#L96-L107

The standard react-json-form button ensures validation, but the JupyterLab buttons does not.

There should be a way to call the validation and not accept the creation if the form is not valid. The validation ways are documented on https://react-jsonschema-form.readthedocs.io/en/latest/usage/validation/

I have quickly tried liveValidate attribute but it does not seem to work.

@echarles echarles changed the title Ensure the form is validated while creating a kernelspect Ensure the form is validated while creating a kernelspec Aug 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant