Skip to content
This repository has been archived by the owner on Feb 4, 2023. It is now read-only.

[FEATURE]: Tests to run on CI (GitHub Actions) #68

Closed
ShaileshKumar007 opened this issue Oct 13, 2021 · 6 comments
Closed

[FEATURE]: Tests to run on CI (GitHub Actions) #68

ShaileshKumar007 opened this issue Oct 13, 2021 · 6 comments
Labels
enhancement New feature or request

Comments

@ShaileshKumar007
Copy link
Member

Description of the feature, you want to add.

Tests not running on push or pull request.

Mention if this feature is for any specific Working Environment (e.g. operating system, browser, device, N/A)

NA

Please add some pictorial references to the feature, if applicable (Drag & Drop your ss below)

NA

What will be your aprroach to add this feature?

Added to GitHub Actions

Any other context you have, to add here regarding this feature.

NA

@ShaileshKumar007 ShaileshKumar007 added the enhancement New feature or request label Oct 13, 2021
@DevrajDC
Copy link
Member

What do you exactly want to solve? The tests work fine only if a PR follows all the contribution guidelines.

@nimishjn
Copy link
Collaborator

What do you exactly want to solve? The tests work fine only if a PR follows all the contribution guidelines.

@ShaileshKumar007 Please provide an answer to the question asked in the comment above.

@ShaileshKumar007
Copy link
Member Author

I'm saying that no tests are running on push or pull requests. Therefore, I think it'll be good if we can add some tests in Github Actions so that these tests will check whether the PRs are valid or spammy.

@DevrajDC
Copy link
Member

I don't have much idea on how GitHub actions will check the tests but You may go ahead and make a PR. I will see how it works, and if its of any benefit than will merge it 🚀

@ShaileshKumar007
Copy link
Member Author

Ok. I'll soon generate a PR for that😃

ShaileshKumar007 added a commit to ShaileshKumar007/Linkify that referenced this issue Oct 19, 2021
Added tests for GitHub Actions
closes Design-and-Code#68
@sidwebworks
Copy link
Member

Let's first finish the features and create test cases before doing all this @DevrajDC

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants