Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can you guys release a version that doesn't include all the dependencies #170

Closed
schmidlop opened this issue Nov 21, 2014 · 5 comments
Closed

Comments

@schmidlop
Copy link

My page already has bootstrap, jQuery etc. why should I have to all of it again?

@ghost
Copy link

ghost commented Nov 21, 2014

+1 👍

@andrew-ml
Copy link
Contributor

Hi everyone,
if we are talking about bootstrap.css and jquery, you don't need any special release for this case, just remove these lines of code from our html:

<link href="../dist/css/vendor/bootstrap.min.css" rel="stylesheet">
<script src="../dist/js/vendor/jquery.min.js"></script>

If you've already used bootstrap.js in your project, you can remove it from gruntfile.js:

 '<%= bower_conf.directory %>/bootstrap/dist/js/bootstrap.js',

and then rebuild project with grunt dist command.

@schmidlop
Copy link
Author

I am referring to the fact that a quick glance in the .min.js file shows all the various license blocks for .js I am including already. So bootstrap is addressed by your comment above. However apparently jQuery can't be removed as doing so breaks flat-ui. Perhaps you could expose the jQuery instance you have embedded so I wouldn't need to include it again?

@andrew-ml
Copy link
Contributor

We don't include jQuery into flat-ui.js, it's linked as an external script: https://github.com/designmodo/Flat-UI/blob/master/index.html#L833
Did you mean jQuery UI ?

@DavidLemayian
Copy link

👍 on removing Bootstrap.js in this repo. Any particular reason for including it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants