Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

noUiSlider v11.1.0 does not work with current CSS !!! #31

Closed
artknight opened this issue Apr 4, 2018 · 6 comments
Closed

noUiSlider v11.1.0 does not work with current CSS !!! #31

artknight opened this issue Apr 4, 2018 · 6 comments
Assignees
Milestone

Comments

@artknight
Copy link

I have upgraded our noUiSlider to the latest version ( 11.1.0 ) and shards-ui CSS breaks the slider. We are forced to resort to the native noUiSlider CSS. Please fix this.

Here is the screenshot of what happens

screen shot 2018-04-04 at 4 22 45 pm

@hisk hisk added this to the Patch 2.0.3 milestone Apr 9, 2018
@hisk
Copy link
Contributor

hisk commented Apr 9, 2018

@artknight Thanks for submitting this and sorry for the huge delay in my response. I'll check and see what other changes and additions are in the latest version of noUiSlider and see if we can accommodate the fix and improvements for the next patch. 😄

@artknight
Copy link
Author

@hisk any idea when this might be released?

@hisk
Copy link
Contributor

hisk commented May 1, 2018

@artknight Expect the next patch (which includes the fix for this issue) to be released in the next few days, at the latest by Monday.

@hisk hisk self-assigned this May 1, 2018
hisk added a commit that referenced this issue May 2, 2018
hisk added a commit that referenced this issue May 2, 2018
* Fix `$popover-arrow-width` interpolation issue #32.

* Update package dependencies.

* Add support for nouislider 11.1.0 - #31

* Update readme.

* Fix demo page responsive display issues #29

* Update dependencies and bump version number.

* Update distributed files.

* Fix readme description.

* Update changelog.
@hisk
Copy link
Contributor

hisk commented May 2, 2018

@artknight This issue was fixed in #33

@hisk hisk closed this as completed May 2, 2018
@artknight
Copy link
Author

artknight commented May 6, 2018

@hisk Thank you for the fix!!! I just double-checked and it indeed works!

I had to make one change though in _custom-slider.scss on line 17

.noUi-handle {
      right: -10px; //changed from -17px
      left: auto;
    }

...otherwise the handles were not aligned correctly.

@hisk
Copy link
Contributor

hisk commented May 6, 2018

@artknight You are right, It should be -10px. 😄 I'll push the fix for this in the upcoming update that will also add support for Bootstrap 4.1.1. Thanks!

jevel9 referenced this issue in zygotecnologia/shards-ui Feb 3, 2019
* Fix `$popover-arrow-width` interpolation issue #32.

* Update package dependencies.

* Add support for nouislider 11.1.0 - #31

* Update readme.

* Fix demo page responsive display issues #29

* Update dependencies and bump version number.

* Update distributed files.

* Fix readme description.

* Update changelog.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants