Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No tests? #41

Closed
vikr01 opened this issue Sep 28, 2018 · 3 comments
Closed

No tests? #41

vikr01 opened this issue Sep 28, 2018 · 3 comments

Comments

@vikr01
Copy link
Contributor

vikr01 commented Sep 28, 2018

Are there any tests in this package? I noticed there isn't a test script in package.json.

@hisk
Copy link
Contributor

hisk commented Oct 2, 2018

@vikr01 Sorry for the delay! I'm afraid there are currently no tests. I use a visual regression testing template locally for each release, but it's not in a great shape and definitely not to be released since it's really messy, has dozens of false-positives that only I know about and would confuse anyone who'd use it. I'd love to have a better and more integrated suite of regression testing integrated with this, but it's not a priority for me right now.

Do you have something in mind? 😊I'm open to suggestions if someone wants to pick this up.

@hisk hisk closed this as completed Oct 8, 2018
@vikr01
Copy link
Contributor Author

vikr01 commented Oct 8, 2018

@hisk I recommend making a feature request issue ticket for this, and labeling it with hacktoberfest so people can find it.

@hisk
Copy link
Contributor

hisk commented Oct 8, 2018

@vikr01 Thanks for your suggestion! 😁I'm on it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants