Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error with get_tile_radius_deg when loading platescale #169

Closed
mathildepinon opened this issue Sep 19, 2023 · 4 comments
Closed

Error with get_tile_radius_deg when loading platescale #169

mathildepinon opened this issue Sep 19, 2023 · 4 comments

Comments

@mathildepinon
Copy link

Hi,

I get an error when I try to use is_point_in_desi from desimodel.footprint. The error comes from get_tile_radius_deg that calls load_platescale which raises a ValueError: invalid column index 8 at row 1 with 8 columns.

It appears that this error is due to issue #166.

I'm using Python 3.10 with numpy 1.24.4.

@araichoor
Copy link

you re running that with the cosmodesi environment, right?

because this error has been fixed in the desimodel here: a98e1ef.

but I happened to bump into today that while running with:

source /global/common/software/desi/users/adematti/cosmodesi_environment.sh main

if I m correct, I think the reason is that the cosmodesi doesn t actually use the "latest" main; so that would be for @adematti.

under this cosmodesi environment, even if "module list" returns desimodel/main, I have in python:

>>> import desimodel
>>> desimodel.__path__
['/global/common/software/desi/users/adematti/perlmutter/cosmodesiconda/20230725-1.0.0/code/desimodel/main/lib/python3.10/site-packages/desimodel']
>>> desimodel.__version__
'0.18.0.dev702'

the desimodel files there date from Sep. 18; and the fix commit has been merged on Sep. 19; and is part of the desimodel/0.19.0 tag version, created on Sep. 25.

if useful, if I load the "normal" desi main environment:

source /global/cfs/cdirs/desi/software/desi_environment.sh main

I then have in python:

>>> import desimodel
>>> desimodel.__path__
['/global/common/software/desi/perlmutter/desiconda/20230111-2.1.0/code/desimodel/main/py/desimodel']
>>> desimodel.__version__
'0.19.0.dev735'

and the load_platescale() function works.

@adematti
Copy link
Member

adematti commented Oct 10, 2023

thanks @araichoor, should be fixed:

>>> source /global/common/software/desi/users/adematti/cosmodesi_environment.sh main
>>> python -c "import desimodel; print(desimodel.__version__)"
0.19.0.dev735

I suggest we close this issue (and #166 as well).

@araichoor
Copy link

thanks, I confirm that it now works fine on my case.
I let @mathildepinon check on her side and, if solved, close the issue.

@mathildepinon
Copy link
Author

Yes it works on my side too. Thanks a lot!

@adematti adematti closed this as completed Apr 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants