Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to latest DESI-doc revisions of data files #24

Closed
dkirkby opened this issue Sep 16, 2016 · 3 comments
Closed

Update to latest DESI-doc revisions of data files #24

dkirkby opened this issue Sep 16, 2016 · 3 comments
Assignees
Milestone

Comments

@dkirkby
Copy link
Member

dkirkby commented Sep 16, 2016

The following files from DESI-0347 are currently based on v5 and need to be updated to v10:

  • desi.yaml
  • inputs/throughput/DESI-0347-throughput.txt

There are also files under inputs/throughput/DESI-0334-spectro from DESI-0334 v3, but that is still the latest version in DocDB.

The file focalplane/platescale.txt claims to be based on DESI-0329 v14, based on this header:

# Echo 22 focal plane parameters from Figure 7 of DESI-0329v14

However, in the more recent v15 this file has the header:

# Echo 22 focal plane parameters from Figure 7 of DESI-0329v3.

However, all other lines look identical so there's something weird in the provenance.

Please update this issue with any other out of date files you are aware of.

@sbailey
Copy link
Contributor

sbailey commented Mar 24, 2017

PR #45 updates:

  • desi.yaml
  • throughput files, with refactoring from original inputs/throughput/DESI-0347-throughput.txt
  • platescale.txt
  • fiberpos.*

platescale.txt provenance: the v15 (and prior) file in DocDB incorrectly references v3. The data actually has changed since v3 (they caught a tan(theta) vs. theta bug) and the latest text file does contain the correct data, it is only the header comment that is incorrect. The version in svn that references "v14" is my fault: I "corrected" that by hand, but doing so silently does make for messy provenance. PR #45 provides more automated DocDB -> data file provenance so I've reverted to using exactly the file as it appears in DocDB without hand editing the comment.

@weaverba137 weaverba137 added this to the DC2017 Prep milestone May 4, 2017
@weaverba137
Copy link
Member

Did the updates ever happen? Will the changes also involve changes to the data model?

@dkirkby
Copy link
Member Author

dkirkby commented May 5, 2017

PR #45 has already been reviewed and merged, so I think this issue can be closed now but @sbailey should confirm.

@sbailey sbailey closed this as completed May 9, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants