Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request: add capability to dither #46

Closed
sybenzvi opened this issue Mar 20, 2017 · 2 comments
Closed

Feature request: add capability to dither #46

sybenzvi opened this issue Mar 20, 2017 · 2 comments
Assignees

Comments

@sybenzvi
Copy link

Hi there,

Last week @sbailey and I discussed adding a dithering feature to the specsim code. Currently the code (through desimodels) allows for specification of the position of the spot on the focal plane, but as far as I can tell it doesn't allow dithering around a source. So I'd like to add this, but before making any changes, a few questions:

  1. I think desimodels is the place to make this addition. Am I right?
  2. I do not see hooks in the existing code for dithering. Did I miss anything?
  3. I'm willing to add the necessary hooks but don't want to collide with changes planned by @dkirkby; I'm told that some refactoring of the project is in the works.

So... if desimodels is the right place and someone else isn't planning to add something similar I'll add the dithering feature to a branch and submit a pull request.

@dkirkby
Copy link
Member

dkirkby commented Mar 20, 2017

This sounds like a straightforward feature to add in specsim, without requiring any changes to desimodel, so I suggest opening a specsim issue and we can discuss further there.

@sybenzvi
Copy link
Author

Will do. Closing the issue here and moving it to specsim.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants