-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update to current DESI-doc versions #88
Comments
Following the instructions in How to update inputs from DocDB, the relevant inputs are:
Since DESI-530 is also out of date (using 2 different old versions!) I will update that also. |
The
However, these cell references look like they describe v14 not v13. Also, the values in these cells:
do not match those in the spreadsheet:
Since these numbers have not changed between v13 and v14, it looks like |
The |
Re-running
Note that Since DESI-334 has not been updated since July 2014, I have pinged Pat and @julienguy to see if there are "as-built" curves we should be using instead. The corrector throughput changes are from updates to C2 (both surfaces) and inclusion of the 4 ADC surfaces (which were ignored before). |
Other changes that affect our simulations are:
The blur changes need to be propagated through to The noise changes need to be propagated through to |
The file The main points are that:
|
The
UPDATE: A comment in the yaml file says that the readnoise is taken from the CDR spec (although I can't find those numbers there). |
Here is a summary of the files I updated in svn under $DESIMODEL/data:
Note that I left the original date (29 Jan 2016) in the UPDATE: Committed UPDATE: Replace random with static offset files. |
@dkirkby thanks for this systematic review and update. Regarding the GFA locations, I confirm that the In addition to updating the docs, I think it would be better for @dkirkby would you like me to make these changes in this branch? |
@sbailey That sounds like a good plan re GFA locations. Please go ahead with the changes in this branch. Is there anything else you think needs updating in |
Note that if we decide to abandon the DESI-347 version of |
I will make the GFA updates later today. In principle systems engineering owns |
One last change to get in synch with how specsim models centroid offsets (since Oct 2017):
Since the centroid errors in DESI-347 did not change between v11-v13, there is no change in the instrument model, just how we implement it in our simulations. The new static RMS value is 8.0 um. The old value was 10.886 um. Since this requires updating the Note that the value of |
v13 of DESI-347 was released 26-Jun-2018 with the following release notes:
Currently (12-July-2018), desimodel is based on v12 of DESI-347. The git package is at tag 0.9.5 and the most recent revision 118070 to the svn
data/
was 4 weeks ago.This issue is to propagate changes from v12 to v13 to the the desimodel svn and git repos. The next step will be to propagate these changes through some benchmark simulations to see the effects on SNR, etc.
The text was updated successfully, but these errors were encountered: