Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

set MPICH_GNI_FORK_MODE=FULLCOPY #1007

Merged
merged 1 commit into from Oct 15, 2020
Merged

set MPICH_GNI_FORK_MODE=FULLCOPY #1007

merged 1 commit into from Oct 15, 2020

Conversation

sbailey
Copy link
Contributor

@sbailey sbailey commented Oct 15, 2020

This PR adds MPICH_GNI_FORK_MODE=FULLCOPY to the desispec.module file, and adds checks for that in desi_proc when running. This is required for MPI+multiprocessing to work together at NERSC. In standard pipeline running, we were getting this environment variable via the redrock module file, but this PR makes sure that we also get it for desispec itself whether or not redrock is loaded, and provides some robustness when running development copies outside of the pre-installed modules.

Other changes that came along for the ride:

  • also added KMP_AFFINITY=disabled, which we also set it redrock modules
  • turns off an error message that wasn't really an error, so that greping for ^ERROR will focus on more genuine errors.

Copy link
Contributor

@julienguy julienguy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested with and without the MPICH_GNI_FORK_MODE env. variable. Both working fine.

@julienguy julienguy merged commit f67e723 into master Oct 15, 2020
@sbailey sbailey deleted the mpi_multiprocessing branch December 17, 2020 20:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants