Nightwatch issue162 warning #1028
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Concept is good, but please run Also, on lines 66 and 69, typically "&" and "|" are reserved for bitwise-and/or operations, while "and" and "or" are used for boolean and/or like here. In this case it is equivalent given your parentheses, but they do have different operator precedence that can have some surprising side effects, so when you are doing operations on booleans (like here) it is generally better to use "and" and "or", and reserve "&" and "|" for cases where you really do mean to be doing bitwise operations on integers. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Nightwatch is unable to handle images with !=500 fibers and this branch issues specific warnings about that.