fix assemble_fibermap for older data with SPS header #1047
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a bug introduced in PR #1045 for older data which have an "SPS" instead of a "SPEC" HDU in the raw data. My penance for introducing the bug is writing unit tests that would have caught the bug in the first place. Since those tests require a substantial amount of real data, they only run at NERSC and are cleanly skipped elsewhere. i.e. Travis / GitHub Actions / Laptop tests won't catch them, but the nightly integration tests at NERSC will.
Speaking of Travis, it is so bogged down now, I plan to merge and update at NERSC so that @akremin can proceed with 20.12 / blanc testing. All tests pass on this branch at NERSC. Retroactive comments are welcome for retroactive fixes.
This fix was tested with the unit tests and the commands