Fix unphysical spikes on the edges of the flux calibration vectors #1065
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PR cures an issue we had on the edges of the flux calibration vectors. The flux calibration fit which comprises convolutions of the model with the resolution matrix is now performed on a data frame with margins along wavelength, and then trimmed back to the original size. The following figure shows in orange the old fluxcalib vector and in blue the new ones, without the unphysical spikes on the edges.