Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Print out messages explaining star selection #1070

Merged
merged 1 commit into from Dec 23, 2020
Merged

Conversation

julienguy
Copy link
Contributor

This PR in response to issue #1066.
The flux calibration selection of stars is now more verbose.
Example for frame-r6-00068675.fits

INFO:fluxcalibration.py:95:main: compute flux calibration
INFO:fluxcalibration.py:111:main: apply cut |delta color|<0.1
INFO:fluxcalibration.py:117:main:  discard 1 stars with dcolor= [0.19936935785406895]
ERROR:fluxcalibration.py:142:main: selection cuts discarded all stars

The delta color test is based on the color of the best fit stellar model. Here a delta color of 0.2 indicates a pretty bad fit.
The color difference can be larger than the initial color selection range because the standard star fitting code includes more stellar parameter grid nodes than given by the script color selection cut in order to have a well behaved input grid geometry (in parameter space).

@julienguy julienguy requested review from akremin and removed request for akremin December 23, 2020 16:23
@sbailey sbailey merged commit 1907be6 into master Dec 23, 2020
@sbailey sbailey deleted the selection-messages branch December 23, 2020 17:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants