Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add FIBER_RA/DEC; support unpositioned coords files #1073

Merged
merged 2 commits into from Dec 24, 2020

Conversation

sbailey
Copy link
Contributor

@sbailey sbailey commented Dec 24, 2020

This PR

  • fixes assemble_fibermap bug for "unpositioned" exposures #1063 by updating assemble_fibermap to support coordinates files that don't have any positioner iterations in them, e.g. 20201220/69082
  • propagates FIBER_RA and FIBER_DEC if present in the coordinates file (e.g. 20201222/69415), but don't crash if they aren't (e.g. 20200315/55611)
  • Renames long keyword "FIBERASSIGN" (>8 char) in early data to match current header name "FIBASSGN" that won't generate HIERARCH warnings.

Tested with

assemble_fibermap -n 20200315 -e 55611 -o fibermap-00055611.fits
assemble_fibermap -n 20201220 -e 69082 -o fibermap-00069082.fits
assemble_fibermap -n 20201222 -e 69415 -o fibermap-00069415.fits

And also tested end-to-end with an "unpositioned" exposure 20201220/69082 with

desi_proc -n 20201220 -e 69082 --batch --traceshift --cameras b1,r1,z1,b2,r2,z2

Outputs in /global/cfs/cdirs/desi/users/sjbailey/spectro/redux/fatest.

@sbailey sbailey merged commit c7a2029 into master Dec 24, 2020
@sbailey sbailey deleted the unpositioned_fibermap branch December 24, 2020 04:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

assemble_fibermap bug for "unpositioned" exposures
1 participant