darkmodel bookkeeping; desi_compute_psf --specmin bugfix #1123
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contributes some bookkeeping updates for computing biases and darks, documenting what was used for the 20210130 update to desi_spectro_calib for the new CCD timing files.
desi_compute_bias --expfilelistoption to specify input NIGHT EXPID in a file instead of N>>1 paths to raw files on the command linedesi_compute_dark_nonlinearoption to group darks with zeros by NIGHT (rolling over at noon, allowing a nighttime dark sequence to span midnight) vs. the previous grouping by DAY (rolling over at midnight, allowing a daytime dark sequence to span noon). Either is supported now by specifying either--daysor--nightsdesi_compute_dark_nonlinear --first-expidoption to specific the first exposure ID to use (e.g. to exclude test exposures with a different configuration earlier in the night).And coming along for the ride is a bug fix to
desi_compute_psf --specminbookkeeping (it wasn't working for specmin>0). This isn't required for normal pipeline operations, but is handy for debugging when PSF fitting a single bundle.