propagate fiberassign HDU0 keywords too #1137
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #1076 where some fiberassign header keywords were not propagated into the fibermap files, thus losing some of the fiber assignment input provenance. The problem was that we were propagating keywords from the 'FIBERASSIGN' HDU, but not additional keywords from HDU 0 of the fiberassign files. Now assemble_fibermap propagates keywords from both HDUs into the fibermap file (along with keywords from the raw data).
Keywords that were previously missing that are now included when running
assemble_fibermap -n 20201215 -e 68065 -o fm-2.fits
:Full disclosure: I renamed the generic "OUTDIR" to "FAOUTDIR" to dis-ambiguate it with other potential output directories. I am slightly tempted to do that for the other input directory keywords too to avoid downstream conflicts in the future.
@moustakas if you happen to see this in time, there is a brief window of opportunity to inspect and comment before we start making tags for Cascades. Example files in
/global/cfs/cdirs/desi/users/sjbailey/spectro/redux/test
:fm-1.fits
fm-2.fits