New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tile completeness #1196
Tile completeness #1196
Conversation
This looks good to me. There are a few things about how the exposure tables are handled that could be tweaked, but those should wait until they have settled down on the exposure table side. Given that this is time-critical, I think it looks great. Note that I didn't actually test it, I only read through it. |
…originally in fiberassign header)
The relevant keywords from the fiberassign files to the tsnr-exposures and tiles tables are now propagated. So this is supposedly ready for SV2 (but obviously not tested on actual SV2 data). It would be great the merge this to master for it to run if we have sv2 designed tiles tonight. Example command for the daily pipeline:
|
Tile completeness code. It's only valid for now for SV1 processing, but I suggest we merge that to have some of the framework in place.
desi_tsnr_afterburner
--tile-completeness
to write a summary tile file with columns:add option
--aux
to use an auxiliary table to get some missing information (actual unique for now case is/global/cfs/cdirs/desi/survey/observations/SV1/sv1-tiles.fits
)add script
desi_tiles_completeness
which produces the same tiles table directly from the tsnr-exposures table.Next (but arguably for another PR, because it would be good to have this in prod as long as we don't have the new fiberassign format in place).