Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tile completeness #1196

Merged
merged 11 commits into from Mar 22, 2021
Merged

Tile completeness #1196

merged 11 commits into from Mar 22, 2021

Conversation

julienguy
Copy link
Contributor

Tile completeness code. It's only valid for now for SV1 processing, but I suggest we merge that to have some of the framework in place.

  • changes to desi_tsnr_afterburner
    • check in prod exposure table for missing/failed exposures and add them with TSNR2=0
    • add option --tile-completeness to write a summary tile file with columns:
TILEID,EXPTIME,NEXP,ELG_EFFTIME_DARK,BGS_EFFTIME_BRIGHT,OBSSTATUS,ZSTATUS,SURVEY,GOALTYP,TARGETS,GOALTIME
...
80619,4801.2,16,1216.9,1109.0,OBSDONE,NONE,SV1,BRIGHT,BGS+MWS,600.0
80620,11700.7,13,8228.4,7875.7,OBSDONE,NONE,SV1,DARK,QSO+LRG,4000.0
80621,9000.5,10,4563.0,4312.9,OBSDONE,NONE,SV1,DARK,ELG,4000.0
80622,7200.4,8,5543.6,5844.3,OBSDONE,NONE,SV1,DARK,QSO+LRG,4000.0
...
  • add option --aux to use an auxiliary table to get some missing information (actual unique for now case is /global/cfs/cdirs/desi/survey/observations/SV1/sv1-tiles.fits)

  • add script desi_tiles_completeness which produces the same tiles table directly from the tsnr-exposures table.

Next (but arguably for another PR, because it would be good to have this in prod as long as we don't have the new fiberassign format in place).

  • use FIBERMAP header keywords to get the info about SURVEY, GOALTYP, GOALTIME , possibly TARGETS.

@coveralls
Copy link

coveralls commented Mar 22, 2021

Coverage Status

Coverage decreased (-0.1%) to 28.805% when pulling 06f1acc on tile-completeness into f3895a1 on master.

@akremin
Copy link
Member

akremin commented Mar 22, 2021

This looks good to me. There are a few things about how the exposure tables are handled that could be tweaked, but those should wait until they have settled down on the exposure table side. Given that this is time-critical, I think it looks great. Note that I didn't actually test it, I only read through it.

@julienguy
Copy link
Contributor Author

The relevant keywords from the fiberassign files to the tsnr-exposures and tiles tables are now propagated. So this is supposedly ready for SV2 (but obviously not tested on actual SV2 data). It would be great the merge this to master for it to run if we have sv2 designed tiles tonight. Example command for the daily pipeline:

desi_tsnr_afterburner -o /global/cfs/cdirs/desi/spectro/redux/daily/tsnr-exposures.fits --prod daily --update --night $LASTNIGHT --tile-completeness /global/cfs/cdirs/desi/spectro/redux/daily/tiles.csv --aux /global/cfs/cdirs/desi/survey/observations/SV1/sv1-tiles.fits --nproc 8

@julienguy julienguy merged commit c0867e9 into master Mar 22, 2021
@julienguy julienguy deleted the tile-completeness branch March 22, 2021 22:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants